Skip to content

DOCSP-45076: Document that count supports different filters from countDocuments #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Dec 9, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45076

Staging Links

  • reference/aggregation
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Dec 9, 2024

    Deploy Preview for docs-ruby ready!

    Name Link
    🔨 Latest commit 171eaee
    🔍 Latest deploy log https://app.netlify.com/sites/docs-ruby/deploys/67570ce97b983e0008646094
    😎 Deploy Preview https://deploy-preview-93--docs-ruby.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    method and may not support the same filters. ``countDocuments`` uses the
    ``$match`` stage of the aggregation pipeline to filter documents. To learn more
    about limitations of the ``$match`` stage, see :manual:`$match Restrictions </reference/operator/aggregation/match/#restrictions>`
    in the MongoDB Server documentation.
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    FYI I can't add a source constant to the snooty file without breaking the build – unsure if it's a quirk fo the Ruby driver (I notice that it doesn't have many constants in the snooty file as is).

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    hm not sure why that is. The {+mdb-server+} constant was added in the standardization branch, but I think it's fine to not use the constant here

    Copy link
    Collaborator

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with a small suggestion

    method and may not support the same filters. ``countDocuments`` uses the
    ``$match`` stage of the aggregation pipeline to filter documents. To learn more
    about limitations of the ``$match`` stage, see :manual:`$match Restrictions </reference/operator/aggregation/match/#restrictions>`
    in the MongoDB Server documentation.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S:

    Suggested change
    in the MongoDB Server documentation.
    in the MongoDB Server manual.

    method and may not support the same filters. ``countDocuments`` uses the
    ``$match`` stage of the aggregation pipeline to filter documents. To learn more
    about limitations of the ``$match`` stage, see :manual:`$match Restrictions </reference/operator/aggregation/match/#restrictions>`
    in the MongoDB Server documentation.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    hm not sure why that is. The {+mdb-server+} constant was added in the standardization branch, but I think it's fine to not use the constant here

    @mcmorisi mcmorisi merged commit 5af3a2e into mongodb:master Dec 9, 2024
    4 of 5 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-45076-count-match-2 branch December 9, 2024 15:31
    mcmorisi added a commit that referenced this pull request Dec 9, 2024
    DOCSP-45076: Document that count supports different filters from countDocuments
    mcmorisi added a commit that referenced this pull request Dec 9, 2024
    DOCSP-45076: Document that count supports different filters from countDocuments
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants